Hi, Since we are already tested out minikube ISO and also have our patch in[0] which make sure it works when there are ISO related changes, it should be tested.

We can also add our PR / nightly tests to point to minikube ISO instead b2d ISO. Any objections/suggestions?

[0] https://github.com/kubernetes/minikube/pull/2177 -- Praveen Kumar http://fedoraproject.org/wiki/User:Kumarpraveen http://fedoraproject.org/ http://kumar-pravin.blogspot.com _______________________________________________ Minishift Mailing List mailing list -- minishift(a)lists.minishift.io To unsubscribe send an email to minishift-leave(a)lists.minishift.io

On Tue, Nov 28, 2017 at 2:12 PM, Lalatendu Mohanty <lmohanty(a)redhat.com&gt; wrote: > > > On Tue, Nov 28, 2017 at 12:06 PM, Praveen Kumar < > kumarpraveen.nitdgp(a)gmail.com&gt; wrote: > >> Hi, >> >> Since we are already tested out minikube ISO and also have our patch >> in[0] which make sure it works when there are ISO related changes, it >> should be tested. >> > > Nice!. > >> >> We can also add our PR / nightly tests to point to minikube ISO >> instead b2d ISO. Any objections/suggestions? >> > > We should first start a parallel job testing with the Minikube ISO for > each PR in Minishift repository [1]. Then after couple of weeks we can make > the switch. > +1. Let's wait for some more time till we have nightly job set for Minikube ISO as well.

> > [1] https://github.com/minishift/minishift/issues/1568 > > -Lala > >> >> [0] https://github.com/kubernetes/minikube/pull/2177 >> >> -- >> Praveen Kumar >> http://fedoraproject.org/wiki/User:Kumarpraveen >> http://fedoraproject.org/ >> http://kumar-pravin.blogspot.com >> _______________________________________________ >> Minishift Mailing List mailing list -- minishift(a)lists.minishift.io >> To unsubscribe send an email to minishift-leave(a)lists.minishift.io >> > > > _______________________________________________ > Minishift Mailing List mailing list -- minishift(a)lists.minishift.io > To unsubscribe send an email to minishift-leave(a)lists.minishift.io > > -- Regards, Budh Ram Gurung